sampler: Add missing gpu_resource_id() getter
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
suggested changes
Jul 14, 2024
There was a problem hiding this comment.
The label is explicitly marked as readonly in the documentation, so I wouldn't rely on it being settable after the creation of the sampler state.
MarijnS95
force-pushed
the
sampler-state-gpu-id
branch
from
9d00e40
to
e7e1dc8
Compare
MarijnS95
changed the title
gpu_resource_id() getter and set_label() settergpu_resource_id() getter
|
Right there's another documentation page that actually describes this. It seems inconsistent at first, but after a while most |
According to the upstream docs and the Metal Shader Converter implementation the `SamplerState` type has a way to get access to its `MTLResourceID` on the GPU: https://developer.apple.com/documentation/metal/mtlsamplerstate/3974101-gpuresourceid
MarijnS95
force-pushed
the
sampler-state-gpu-id
branch
from
e7e1dc8
to
608c613
Compare
cwfitzgerald
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the upstream docs and the Metal Shader Converter implementation the
SamplerStatetype has a way to get access to itsMTLResourceIDon the GPU: https://developer.apple.com/documentation/metal/mtlsamplerstate/3974101-gpuresourceid